| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Unused struct member in pgcrypto pgp.c |
| Date: | 2019-07-31 05:38:11 |
| Message-ID: | CALDaNm0tGyUKa8d-i_s7cgRptee-Vt06qDJgMSCPuiQD1FTpHA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 30, 2019 at 9:19 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> Hi,
>
> In contrib/pgcrypto/pgp.c we have a struct member int_name in digest_info which
> isn’t used, and seems to have never been used (a potential copy/pasteo from the
> cipher_info struct?). Is there a reason for keeping this, or can it be removed
> as per the attached?
>
Agreed.
It seems the member is not being used anywhere, only code and name members
are being used in digest lookup.
Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-07-31 05:47:41 | Re: [HACKERS] advanced partition matching algorithm for partition-wise join |
| Previous Message | Michael Paquier | 2019-07-31 05:31:39 | Re: Possible race condition in pg_mkdir_p()? |