From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Make default subscription streaming option as Parallel |
Date: | 2024-10-22 15:56:10 |
Message-ID: | CALDaNm0mWWocJmMDC==DO=R6-YdLY5rucreACs4SMrzRpz8-0w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, 22 Oct 2024 at 16:24, Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Amit, Vignesh,
>
> > 1. Please ensure that none of the existing tests that use
> > subscriptions with large changes will be impacted due to this change.
>
> I found at least 022_twophase_cascade.pl should be fixed.
> The file has a part which tests non-streaming case:
>
> ```
> # -----------------------
> # 2PC NON-STREAMING TESTS
> # -----------------------
> ...
> $node_B->safe_psql(
> 'postgres', "
> CREATE SUBSCRIPTION tap_sub_B
> CONNECTION '$node_A_connstr application_name=$appname_B'
> PUBLICATION tap_pub_A
> WITH (two_phase = on)");
> ...
> ```
>
> I know the streaming actually does not happen because few tuples will be inserted
> later, but creating as streaming=parallel is bit misleading.
The attached v5 version has the change to create subscriptions in
streaming off mode. I also did not find any other TAP test which
required further changes.
Regards,
Vignesh
Attachment | Content-Type | Size |
---|---|---|
v5-0001-Change-the-default-value-of-the-streaming-option-.patch | text/x-patch | 23.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2024-10-22 16:11:32 | Re: Pgoutput not capturing the generated columns |
Previous Message | Tom Lane | 2024-10-22 15:37:03 | Re: Better error reporting from extension scripts (Was: Extend ALTER OPERATOR) |