Re: Make default subscription streaming option as Parallel

On Tue, 22 Oct 2024 at 16:24, Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Amit, Vignesh,
>
> > 1. Please ensure that none of the existing tests that use
> > subscriptions with large changes will be impacted due to this change.
>
> I found at least 022_twophase_cascade.pl should be fixed.
> The file has a part which tests non-streaming case:
>
> ```
> # -----------------------
> # 2PC NON-STREAMING TESTS
> # -----------------------
> ...
> $node_B->safe_psql(
> 'postgres', "
> CREATE SUBSCRIPTION tap_sub_B
> CONNECTION '$node_A_connstr application_name=$appname_B'
> PUBLICATION tap_pub_A
> WITH (two_phase = on)");
> ...
> ```
>
> I know the streaming actually does not happen because few tuples will be inserted
> later, but creating as streaming=parallel is bit misleading.

The attached v5 version has the change to create subscriptions in
streaming off mode. I also did not find any other TAP test which
required further changes.

Regards,
Vignesh