Tab completion not listing schema list for create/alter publication for all tables in schema

From: vignesh C <vignesh21(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Tab completion not listing schema list for create/alter publication for all tables in schema
Date: 2022-03-13 17:03:43
Message-ID: CALDaNm0hBO+tZqBWhBjTVxyET1GWANq5K9XpQ07atSxnFXbG7w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I noticed that the following commands "CREATE PUBLICATION pub1 FOR ALL
TABLES IN SCHEMA" and "ALTER PUBLICATION pub1 ADD ALL TABLES IN
SCHEMA" does not complete with the schema list. I feel this is because
of the following code in tab-complete.c:
.........
COMPLETE_WITH_QUERY_PLUS(Query_for_list_of_schemas
" AND nspname NOT LIKE E'pg\\\\_%'",
"CURRENT_SCHEMA");
.........
Here "pg\\\\_%" should be "pg\\\\_%%".
Attached a patch to handle this.
Thoughts?

Regards,
Vignesh

Attachment Content-Type Size
0001-Tab-completion-not-listing-schema-list-for-create-al.patch text/x-patch 1.6 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2022-03-13 17:05:27 Re: Issue with pg_stat_subscription_stats
Previous Message Zhihong Yu 2022-03-13 14:05:10 Re: BufferAlloc: don't take two simultaneous locks