Re: Option to dump foreign data in pg_dump

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Luis Carril <luis(dot)carril(at)swarm64(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Option to dump foreign data in pg_dump
Date: 2020-01-28 01:59:09
Message-ID: CALDaNm0Tt+G4Ht6oUezej6nUzh6PtFqi+LnNWo1Njb==50OM6w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 21, 2020 at 3:06 PM Luis Carril <luis(dot)carril(at)swarm64(dot)com> wrote:
>
> Yes we can support --include-foreign-data without parallel option and
> later add support for parallel option as a different patch.
>
> Hi,
>
> I've attached a new version of the patch in which an error is emitted if the parallel backup is used with the --include-foreign-data option.
>

Thanks for working on the comments. I noticed one behavior is
different when --table option is specified. When --table is specified
the following are not getting dumped:
CREATE SERVER foreign_server

I felt the above also should be included as part of the dump when
include-foreign-data option is specified.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-01-28 02:03:03 Re: BufFileRead() error signalling
Previous Message Kohei KaiGai 2020-01-28 01:55:11 Is custom MemoryContext prohibited?