From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Subject: | Re: Added schema level support for publication. |
Date: | 2021-09-14 08:38:30 |
Message-ID: | CALDaNm0OudeDeFN7bSWPro0hgKx=1zPgcNFWnvU_G6w3mDPX0Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Sep 13, 2021 at 5:11 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Sun, Sep 12, 2021 at 8:43 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > Thanks for the changes, the suggested changes make the parsing code
> > simpler. I have merged the changes to the main patch. Attached v27
> > patch has the changes for the same.
> >
>
> +pubobj_name: ColId { $$ = list_make1(makeString($1)); }
> + | ColId indirection { $$ = lcons(makeString($1), $2); }
> ;
>
> I think "ColId indirection" should handle catalog and schema name as
> we are doing in qualified_name. See attached (this can be applied atop
> v27-0002). The one other improvement we can do here is to extract the
> common code from qualified_name (especially for "ColId indirection")
> and pubobj_name. What do you think?
I have handled this in the patch attached.
Regards,
Vignesh
Attachment | Content-Type | Size |
---|---|---|
v28-0001-Made-the-existing-relation-cache-invalidation-an.patch | text/x-patch | 5.9 KB |
v28-0002-Added-schema-level-support-for-publication.patch | text/x-patch | 74.9 KB |
v28-0003-Client-side-changes-to-support-FOR-ALL-TABLES-IN.patch | text/x-patch | 21.6 KB |
v28-0004-Tests-for-FOR-ALL-TABLES-IN-SCHEMA-publication.patch | text/x-patch | 52.2 KB |
v28-0005-Documentation-for-FOR-ALL-TABLES-IN-SCHEMA-publi.patch | text/x-patch | 15.4 KB |
v28-0006-Implemented-pg_publication_objects-view.patch | text/x-patch | 6.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2021-09-14 08:45:01 | Re: Added schema level support for publication. |
Previous Message | Andrey V. Lepikhov | 2021-09-14 06:43:03 | Re: Increase value of OUTER_VAR |