Re: Commit fest 2025-03

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Commit fest 2025-03
Date: 2025-03-06 17:00:30
Message-ID: CALDaNm0N7hhM+VyvsVBZznXNgSXiHjk7uoJsGYuh9JtVGwXrpQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 6 Mar 2025 at 21:24, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> vignesh C <vignesh21(at)gmail(dot)com> writes:
> > On Wed, 5 Mar 2025 at 16:50, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de> wrote:
> >> Is there something wrong with the commitfest app? This patch applies
> >> cleanly and passes all tests
>
> > I verified that it applies neatly and passes the tests for me too, I
> > have reported this issue at [1]. I don't know the reason for this.
>
> What did you apply with? "git am" is known to be far pickier than
> "patch". (I thought the cfbot was using "patch", but I might be
> wrong. There are many versions of "patch", too.)

In my local environment I used "git am" and it worked fine. cfbot has
used "git apply --3way" as per [1], they are planning to change it to
"git am" to fix this issue.
[1] - https://www.postgresql.org/message-id/CAGECzQSE7igwsTUk17i%2BRNEUL1zR-Zkp-1Zs7KkhmBxAu_Fksw%40mail.gmail.com

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-03-06 17:04:04 Re: bogus error message for ALTER TABLE ALTER CONSTRAINT
Previous Message Andrew Dunstan 2025-03-06 16:57:05 Re: what's going on with lapwing?