| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-07-02 09:39:59 |
| Message-ID: | CALDaNm0AcaHLv9dW0Rjww9f6BJxYLMPCWOiO_awV0kemTz-Tvg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 26 Jun 2024 at 14:41, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Here are my initial review comments for the first patch v20240625-0001.
>
> ======
> General
>
> 6.
> I saw that RelationNeedsWAL() is called 2 times. It may make no sense,
> but is it possible to assign that to a variable 1st time so you don't
> need to call it 2nd time within the critical section?
>
I felt this is ok, we do similarly in other places also like
fill_seq_fork_with_data function in the same file.
I have fixed the other comments and merged the nitpicks changes. The
attached patch has the changes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v20240702-0001-Introduce-pg_sequence_state-and-SetSequenc.patch | text/x-patch | 13.9 KB |
| v20240702-0003-Enhance-sequence-synchronization-during-su.patch | text/x-patch | 52.6 KB |
| v20240702-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch | text/x-patch | 91.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2024-07-02 09:42:06 | Re: Optimize numeric.c mul_var() using the Karatsuba algorithm |
| Previous Message | Erik Wienhold | 2024-07-02 09:37:45 | Re: Underscore in positional parameters? |