| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Provide more information to filter_prepare |
| Date: | 2021-03-29 13:37:58 |
| Message-ID: | CALDaNm090UzuJjR6ZFFitd1+69NAOx9LqLaMVk_O+rg1Tvjpyw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 29, 2021 at 5:40 PM Markus Wanner
<markus(dot)wanner(at)enterprisedb(dot)com> wrote:
>
> On 29.03.21 14:00, vignesh C wrote:
> > Have you intentionally not
> > written any tests as it will be difficult to predict the xid. I just
> > wanted to confirm my understanding.
>
> Yeah, that's the reason this is hard to test this with a regression
> test. It might be possible to come up with a TAP test for this, but I
> doubt that's worth it, as it's a pretty trivial addition.
>
Thanks, I don't have any more comments.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2021-03-29 13:52:10 | Re: [PATCH v3 1/1] Fix detection of preadv/pwritev support for OSX. |
| Previous Message | David Steele | 2021-03-29 13:36:30 | Re: parallel distinct union and aggregate support patch |