| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-07-03 14:40:55 |
| Message-ID: | CALDaNm05Ro6TdybrTumjNFkJhw_QS2TcSh8pmfnnqe_+PU4Xcg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 3 Jul 2024 at 08:24, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Here are my comments for patch v20240702-0001
>
> They are all cosmetic and/or typos. Apart from these the 0001 patch LGTM.
>
> ======
> doc/src/sgml/func.sgml
>
> Section 9.17. Sequence Manipulation Functions
>
> pg_sequence_state:
> nitpick - typo /whethere/whether/
> nitpick - reworded slightly using a ChatGPT suggestion. (YMMV, so it
> is fine also if you prefer the current wording)
>
> ======
> src/backend/commands/sequence.c
>
> SetSequenceLastValue:
> nitpick - typo in function comment /diffrent/different/
>
> pg_sequence_state:
> nitpick - function comment wording: /page LSN/the page LSN/
> nitpick - moved some comment details about 'lsn_ret' into the function header
> nitpick - rearranged variable assignments to have consistent order
> with the values
> nitpick - tweaked comments
> nitpick - typo /whethere/whether/
>
> ======
> 99.
> Please see the attached diffs patch which implements all those
> nitpicks mentioned above.
Thank you for your feedback. I have addressed all the comments in the
v20240703 version patch attached at [1].
[1] - https://www.postgresql.org/message-id/CALDaNm0mSSrvHNRnC67f0HWMpoLW9UzxGVXimhwbRtKjE7Aa-Q%40mail.gmail.com
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-07-03 14:41:40 | Re: Add a GUC check hook to ensure summarize_wal cannot be enabled when wal_level is minimal |
| Previous Message | vignesh C | 2024-07-03 14:39:24 | Re: Logical Replication of sequences |