| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-08-07 08:15:39 |
| Message-ID: | CALDaNm01Z6Oo9osGMFTOoyTR1kVoyh1rEvZ+6uJn-ZymV=0dbQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 6 Aug 2024 at 14:38, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Here are some review comments for the patch v20240805_2-0003.
>
> 4a.
> Is there a way to give more helpful information by identifying what
> was different in the log? OTOH, maybe it would become too messy if
> there were multiple differences...
I had considered this while implementing and did not implement it to
print each of the parameters because it will be too messy. I felt
existing is better.
>
> 7. More test cases?
> IIUC you can also get a sequence mismatch warning during "ALTER ...
> REFRESH PUBLICATION", and "CREATE SUBSCRIPTION". So, should those be
> tested also?
Since it won't add any extra coverage, I feel no need to add this test.
The remaining comments have been addressed, and the changes are
included in the attached v20240807 version patch.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v20240807-0001-Introduce-pg_sequence_state-function-for-e.patch | text/x-patch | 11.4 KB |
| v20240807-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch | text/x-patch | 90.2 KB |
| v20240807-0003-Enhance-sequence-synchronization-during-su.patch | text/x-patch | 105.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-08-07 08:25:36 | Re: Logical Replication of sequences |
| Previous Message | Peter Smith | 2024-08-07 08:00:37 | Re: Pgoutput not capturing the generated columns |