Re: src/bin/pg_upgrade/t/004_subscription.pl test comment fix

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: src/bin/pg_upgrade/t/004_subscription.pl test comment fix
Date: 2024-01-31 05:51:03
Message-ID: CALDaNm01N+66UWJ004-m27aL=coZzcxmf8kzSuZP33zcRypeFQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 31 Jan 2024 at 10:27, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi,
>
> PSA a small fix for a misleading comment found in the pg_upgrade test code.

Is the double # intentional here, as I did not see this style of
commenting used elsewhere:
+# # Upgraded regress_sub1 should still have enabled and failover as true.
+# # Upgraded regress_sub2 should still have enabled and failover as false.

Regards,
Vignesh

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-01-31 05:55:39 Re: Documentation: warn about two_phase when altering a subscription
Previous Message Masahiko Sawada 2024-01-31 05:49:21 Re: [PoC] Improve dead tuple storage for lazy vacuum