Warn when parallel restoring a custom dump without data offsets

From: David Gilman <davidgilman1(at)gmail(dot)com>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Warn when parallel restoring a custom dump without data offsets
Date: 2020-05-16 20:57:46
Message-ID: CALBH9DDuJ+scZc4MEvw5uO-=vRyR2=QF9+Yh=3hPEnKHWfS81A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

If pg_dump can't seek on its output stream when writing a dump in the
custom archive format (possibly because you piped its stdout to a file)
it can't update that file with data offsets. These files will often
break parallel restoration. Warn when the user is doing pg_restore on
such a file to give them a hint as to why their restore is about to
fail.

The documentation for pg_restore -j is also updated to suggest that you
dump custom archive formats with the -f option.
---
doc/src/sgml/ref/pg_restore.sgml | 9 +++++++++
src/bin/pg_dump/pg_backup_custom.c | 8 ++++++++
2 files changed, 17 insertions(+)

Attachment Content-Type Size
0001-Warn-when-parallel-restoring-a-custom-dump-without-d.patch application/octet-stream 2.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2020-05-16 21:45:39 Re: Add A Glossary
Previous Message Euler Taveira 2020-05-16 19:44:13 Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format