| From: | Roberto Mello <roberto(dot)mello(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, zxwsbg12138(at)gmail(dot)com, david(dot)zhang(at)highgo(dot)ca |
| Subject: | Re: Requiring recovery.signal or standby.signal when recovering with a backup_label |
| Date: | 2023-10-30 16:32:28 |
| Message-ID: | CAKz==bJk=T_Cbs5ybsWbodpBg3Q2939kT1phbO_jBs8PjeHQpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 30, 2023 at 1:09 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> I have been reviewing the patch, and applied portions of it as of
> dc5bd388 and 1ffdc03c and they're quite independent pieces. After
> that, the remaining bits of the patch to change the behavior is now
> straight-forward. I have written a commit message for it, while on
> it, as per the attached.
>
A suggestion for the hint message in an effort to improve readability:
"If you are restoring from a backup, ensure \"%s/recovery.signal\" or
\"%s/standby.signal\" is present and add required recovery options."
I realize the original use of "touch" is a valid shortcut for what I
suggest above, however that will be less clear for the not-so-un*x-inclined
users of Postgres, while for some it'll be downright confusing, IMHO. It
also provides the advantage of being crystal clear on what needs to be done
to fix the problem.
Roberto
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-10-30 16:39:23 | Re: always use runtime checks for CRC-32C instructions |
| Previous Message | Nathan Bossart | 2023-10-30 16:21:43 | Re: CRC32C Parallel Computation Optimization on ARM |