Re: fallocate / posix_fallocate for new WAL file creation (etc...)

From: Jon Nelson <jnelson+pgsql(at)jamponi(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Jim Nasby <jim(at)nasby(dot)net>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Amit Kapila <amit(dot)kapila(at)huawei(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Florian Pflug <fgp(at)phlo(dot)org>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: fallocate / posix_fallocate for new WAL file creation (etc...)
Date: 2013-05-16 13:16:33
Message-ID: CAKuK5J0D8pb223Y1tq7VAO-pixadG8NXjf3gpFtMb8QGVgJ4+A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 15, 2013 at 10:36 PM, Jon Nelson <jnelson+pgsql(at)jamponi(dot)net> wrote:
> On Wed, May 15, 2013 at 10:17 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
>> Jon Nelson escribió:
>>> On Wed, May 15, 2013 at 4:46 PM, Jon Nelson <jnelson+pgsql(at)jamponi(dot)net> wrote:
>>
>>> > That's true. I originally wrote the patch using fallocate(2). What
>>> > would be appropriate here? Should I switch on the return value and the
>>> > six (6) or so relevant error codes?
>>>
>>> I addressed this, hopefully in a reasonable way.
>>
>> Would it work to just assign the value you got from posix_fallocate (if
>> nonzero) to errno and then use %m in the errmsg() call in ereport()?
>
> That strikes me as a better way. I'll work something up soon.
> Thanks!

Please find attached version 3.
Am I doing this the right way? Should I be posting the full patch each
time, or incremental patches?

--
Jon

Attachment Content-Type Size
fallocate-v3.patch application/octet-stream 6.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2013-05-16 13:32:14 Re: counting algorithm for incremental matview maintenance
Previous Message Christoph Berg 2013-05-16 13:14:44 Re: plperl segfault in plperl_trusted_init() on kfreebsd