From: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
---|---|
To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
Cc: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete) |
Date: | 2020-07-08 12:41:39 |
Message-ID: | CAKtn9dP42m-AdA7iNwb8JA7izwj0R4CA8gpNohCDr6SMmeZGGg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Hackers,
Following patch includes fix for :
Storage parameters should be displayed in parent tables's SQL.
As the code will be upgraded in feature #5649
<https://redmine.postgresql.org/issues/5649>, so only initial test cases
for pg 10, 11 are included in this patch, so later it can be continued with
the latest code.
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
On Mon, Jul 6, 2020 at 2:27 PM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi Rahul,
>
> - The storage parameters should be displayed in the parent table's SQL too
> - Please write test cases, preferably re-sql test cases
>
> Thanks,
> Khushboo
>
> On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Khushboo,
>>
>> Can you please review it.
>>
>> On Sat, Jul 4, 2020 at 1:45 AM Rahul Shirsat <
>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Please find the attached patch which fixes the issue related to the
>>> partition table with storage parameters.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Attachment | Content-Type | Size |
---|---|---|
RM5569_v2.patch | application/octet-stream | 54.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Pradip Parkale | 2020-07-08 13:58:44 | [pgAdmin][RM5633]:Create RLS Policy option enabled for catalog objects |
Previous Message | Yogesh Mahajan | 2020-07-08 10:47:00 | [pgAdmin][Patch] RM 5463 - CSV download quotes numeric columns |