Re: SonarQube Fixes #3 + RM5985[pgAdmin4] Bgprocess watcher dialog box disappers and error occurs after server is removed

From: Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: SonarQube Fixes #3 + RM5985[pgAdmin4] Bgprocess watcher dialog box disappers and error occurs after server is removed
Date: 2020-11-11 20:45:11
Message-ID: CAKtn9dOD=XcqV=SfNR1NYRPenJ-YOSrHXBePbhSGZLk0RsbFDA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Hackers,

Please find below attached patch which fixes:
1. Bgprocess watcher dialog box disappearing after server is removed
2. Removed 3 dots on Storage Manager Dialog box (Storage Manager... to
Storage Manager)
3. Previous sonarqube issues carry forward in this patch.

Rest I haven't got any user_old specific issues while removing the orphan
process, I think, programmatically, it is handled.

Note: Previous sonarqube issue in this mail trace is also considered in
this patch due to many similar file changes.

On Tue, Nov 10, 2020 at 1:59 PM Rahul Shirsat <
rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:

> Hi Hackers,
>
> Minor sonar issues too fixed. Find the updated patch.
>
> On Mon, Nov 9, 2020 at 2:53 PM Rahul Shirsat <
> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch to fix the SonarQube code smells having
>> rules:
>>
>> - Refactor this function to reduce its Cognitive Complexity from 24
>> to the 15 allowed.
>>
>> Also, corrected one of the backup test cases which were failing in server
>> mode.
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>

--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.

Attachment Content-Type Size
RM5985.patch application/octet-stream 8.5 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Nikhil Mohite 2020-11-12 06:52:36 [pgAdmin][RM-5974]: Debugger tab title (placeholders) does not apply to debugger opened in the new browser tab.
Previous Message Nikhil Mohite 2020-11-11 11:41:52 [pgAdmin][RM-5983]:Add server type icon on new connection dialog.