Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

Hi Khushboo,

I had already corrected the patch as soon as I saw your mail, but couldn't
send you as I went out on an urgency. Now sending it.

On Fri, Jul 10, 2020 at 10:25 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Rahul,
>
> I am getting errors while applying the patch, please rebase the patch and
> send it again.
>
> Thanks,
> Khushboo
>
> On Thu, Jul 9, 2020 at 1:25 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Khushboo
>>
>> Can you please review it.
>>
>> On Wed, Jul 8, 2020 at 6:12 PM Rahul Shirsat <
>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Following patch includes fix for :
>>>
>>> Storage parameters should be displayed in parent tables's SQL.
>>>
>>> As the code will be upgraded in feature #5649
>>> <https://redmine.postgresql.org/issues/5649>, so only initial test
>>> cases for pg 10, 11 are included in this patch, so later it can be
>>> continued with the latest code.
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>> On Mon, Jul 6, 2020 at 2:27 PM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Rahul,
>>>>
>>>> - The storage parameters should be displayed in the parent table's SQL
>>>> too
>>>> - Please write test cases, preferably re-sql test cases
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>> On Mon, Jul 6, 2020 at 11:28 AM Akshay Joshi <
>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Khushboo,
>>>>>
>>>>> Can you please review it.
>>>>>
>>>>> On Sat, Jul 4, 2020 at 1:45 AM Rahul Shirsat <
>>>>> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Please find the attached patch which fixes the issue related to the
>>>>>> partition table with storage parameters.
>>>>>>
>>>>>> --
>>>>>> *Rahul Shirsat*
>>>>>> Software Engineer | EnterpriseDB Corporation.
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect*
>>>>> *EnterpriseDB Software India Private Limited*
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>
>>> --
>>> *Rahul Shirsat*
>>> Software Engineer | EnterpriseDB Corporation.
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.