| From: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | [pgAdmin4][Patch] - SonarQube Fixes #2 |
| Date: | 2020-08-14 15:03:25 |
| Message-ID: | CAKtn9dNQ0GLh4yqwWAoTk63R-cVGfHh0hujX1Tv6-sGSNvFwpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Hackers,
Please find the attached patch to fix the SonarQube Code smells having Rule:
1. Define a constant instead of duplicating this literal
"browser/css/node.css" 4 times.
2. Define a constant instead of duplicating this literal "The specified
table could not be found." 10 times.
3. Define a constant instead of duplicating this literal
'get_columns_for_table.sql' 3 times.
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
| Attachment | Content-Type | Size |
|---|---|---|
| sonar_qube_table_init.patch | application/octet-stream | 17.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Domenico Sgarbossa | 2020-08-14 15:43:32 | Re: Translators: Release next week |
| Previous Message | Akshay Joshi | 2020-08-14 11:59:39 | Translators: Release next week |