From: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][patch] RM6675 Port package and it’s child node to React |
Date: | 2021-08-19 08:05:49 |
Message-ID: | CAKtn9dMOZBD1kqJt_+WkdLEV5ohhqkRBV16UTzMx9s367jrqTg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hello Akshay,
My bad. I haven't mentioned that this is a known issue which is mentioned
in the "pgAdmin Nodes to React" sheet. So it's a known issue.
Also, the changes on the Properties panel made is for only showing fullTab
display for Code mirror wherever applicable.
On Wed, Aug 18, 2021 at 7:55 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Rahul
>
> On Wed, Aug 18, 2021 at 12:31 PM Rahul Shirsat <
> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch which ports package and its child nodes to
>> react.
>>
>> A minor change of fullTab for sql type is added for the Properties tab.
>>
>
> The above change broke the visibility of the content of the code
> mirror in the Properties panel for all the nodes (wherever applicable).
> With your patch select any trigger function, package, edb functions
> and verify in the Properties panel.
>
>>
>> --
>> *Rahul Shirsat*
>> Senior Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
*Rahul Shirsat*
Senior Software Engineer | EnterpriseDB Corporation.
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2021-08-19 10:01:08 | pgAdmin 4 commit: Renamed 'Auto rollback?' to 'Auto rollback on error?' |
Previous Message | Akshay Joshi | 2021-08-18 14:25:31 | Re: [pgAdmin][patch] RM6675 Port package and it’s child node to React |