| From: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][RM3318] Download Backup Files |
| Date: | 2020-10-23 10:05:00 |
| Message-ID: | CAKtn9dM9F_SdYOBt9bSYq32bXyL2hmtUzto-Lx6ECZV1WOwA2w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Akshay,
Please find below comments on review points.
On Wed, Oct 21, 2020 at 4:56 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Rahul
>
> Following are the review comments:
>
> - Add "..." to the Storage Manager menu - *DONE*
> - Storage manager icon is not visible on process watcher if we provide
> file name without directory. - *DONE*
> - Renaming the directory not working from Storage Manager. - As
> discussed in scrum update on 23'Oct, this issue would be taken care in
> RM5943 <https://redmine.postgresql.org/issues/5943>
>
> Please fix and send the patch.
>
> On Tue, Oct 20, 2020 at 9:27 PM Rahul Shirsat <
> rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find the below patch which allows users to download the backup and
>> export files generated on shared drive.
>>
>> --
>> *Rahul Shirsat*
>> Software Engineer | EnterpriseDB Corporation.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
| Attachment | Content-Type | Size |
|---|---|---|
| RM3318_v3.patch | application/octet-stream | 89.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-10-23 11:47:07 | pgAdmin 4 commit: Added support to rename query tool and debugger tabs. |
| Previous Message | Nikhil Mohite | 2020-10-23 09:45:28 | [pgAdmin][RM-4230]: Rename tab. |