From: | Rahul Shirsat <rahul(dot)shirsat(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][Patch] #4059 Query Tool button in Query Tool to open a new Query Window |
Date: | 2020-08-27 14:45:29 |
Message-ID: | CAKtn9dM5woCVYAc5dKAZ=eSuoDCw1HnJFNcX_=mduQ25Q16Bjg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Please find the update patch attached here.
On Thu, Aug 27, 2020 at 8:10 PM Rahul Shirsat <
rahul(dot)shirsat(at)enterprisedb(dot)com> wrote:
> Hi Hackers,
>
> Please find the attached patch below which adds the functionality of the
> query tool button in the query tool sqleditor.
>
> *Acceptance criteria:*
> - For sqleditor on same window & on new tab:
>
> - When a query tool connection is initiated, as expected it will open
> the connection based on the selected database in the treeview. Now, when
> the user clicks the query tool connection button on the query tool window,
> irrespective of the selected database in treeview, it should open a
> connection based on the query tool connected database.
> - Similarly, for a new tab, clicking on the query tool connection
> button, it should open a connection based on the query tool connected
> database, instead of selected treeview node.
>
> [image: query tool button.png]
>
> Additionally, an error is handled in the form of message dialog prompting
> the user to initiate the connection, when sqleditor is opened in the new
> tab with the main application window kept closed. This can be reviewed by
> refreshing the window as well as clicking on the query tool connection
> button.
>
> A prompt dialog message box is seen as:
>
> [image: Screen Shot 2020-08-27 at 8.04.33 PM.png]
>
> --
> *Rahul Shirsat*
> Software Engineer | EnterpriseDB Corporation.
>
--
*Rahul Shirsat*
Software Engineer | EnterpriseDB Corporation.
Attachment | Content-Type | Size |
---|---|---|
RM4059_v2.patch | application/octet-stream | 5.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Yogesh Mahajan | 2020-08-27 15:29:42 | [pgAdmin][Patch] RM5426 - [pgagent]: Codemirror control height should use maximum space while creating jobstep |
Previous Message | Rahul Shirsat | 2020-08-27 14:40:30 | [pgAdmin][Patch] #4059 Query Tool button in Query Tool to open a new Query Window |