| From: | sirisha chamarthi <sirichamarthi22(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: Catalog_xmin is not advanced when a logical slot is lost |
| Date: | 2022-11-21 15:18:09 |
| Message-ID: | CAKrAKeWR0dgdwZpnFupyJdB9u5d9kfJXrs_5wAwDRG41Grd4_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks Alvaro, Ashutosh for your comments.
On Mon, Nov 21, 2022 at 6:20 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
wrote:
> On 2022-Nov-21, Ashutosh Bapat wrote:
>
> > Maybe. In that case pg_get_replication_slots() should be changed. We
> > should use the same criteria to decide whether a slot is invalidated
> > or not at all the places.
>
> Right.
>
Agreed.
>
> > I am a fan of stricter, all-assumption-covering conditions. In case we
> > don't want to check restart_lsn, an Assert might be useful to validate
> > our assumption.
>
> Agreed. I'll throw in an assert.
>
Changed this in the patch to throw an assert.
> --
> Álvaro Herrera PostgreSQL Developer —
> https://www.EnterpriseDB.com/
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0002-Ignore-invalidated-slots-while-computing-the-oldest-.patch | application/octet-stream | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ilya Gladyshev | 2022-11-21 15:20:06 | postgres_fdw binary protocol support |
| Previous Message | Simon Riggs | 2022-11-21 15:14:07 | Re: Damage control for planner's get_actual_variable_endpoint() runaway |