| From: | "Ivan N(dot) Taranov" <i(dot)taranov(at)postgrespro(dot)ru> |
|---|---|
| To: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: custom postgres launcher for tests |
| Date: | 2020-03-17 11:35:08 |
| Message-ID: | CAKqLMA8peHBEszaB27Zf2+xBgh4t=7g4kVv3S7Jz7=2BWsureA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> If we support a wrapper we should support it for all pg_ctl usage IMO.
As i understand it - you propose to patch pg_ctl.c & regress.c instead of
PostgresNode.pm & regress.c?
This is a deeper invasion to pg_ctl. There will be a conflict between the
environment variable and the pg_ctl -p parameter, and possibly induced
bugs.
I suggest microscopic changes for iterative recompilation/test/debug
without installation.
> For the sake of others with similar needs I attach my current
> wrapper/launcher script. To use it you have to:
IMHO, the method what you proposed (wrapper/launcher) - is more suitable for
complex testing.
I agree that the my proposed way is incomplete.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-03-17 11:44:35 | Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager |
| Previous Message | Antonin Houska | 2020-03-17 11:06:48 | Assert() failures during RI checks |