Re: Feedback on table expansion hook (including patch)

From: yuzuko <yuzukohosoya(at)gmail(dot)com>
To: Erik Nordström <erik(at)timescale(dot)com>
Cc: David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Feedback on table expansion hook (including patch)
Date: 2021-05-12 07:48:29
Message-ID: CAKkQ50_zY4GaULO1_vuPh3mheTUe8BOTpJiqN5-xtrk6M6fF=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

> Thank you all for the feedback and insights.
>
> Yes, the intention is to *replace* expand_inherited_rtentry() in the same way planner_hook replaces standard_planner().
>

This patch is really useful. We are working on developing hypothetical
partitioning as a feature of HypoPG[1][2], but we hit the same problem
as TimescaleDB. Therefore we would also be thrilled to have that hook.

Hypothetical partitioning allows users to define multiple partitioning
schemes on real tables and real data hypothetically, and shows resulting
queries' plan/cost with EXPLAIN using hypothetical partitioning schemes.
Users can quickly check how their queries would behave if some tables
were partitioned, and try different partitioning schemes. HypoPG does
table expansion again according to the defined hypothetical partitioning
schemes. For this purpose, we used get_relation_info hook, but in PG12,
table expansion was moved, so we cannot do that using
get_relation_info hook. This is exactly the same problem Erik has.
Therefore the proposed hook would allow us to support hypothetical partitioning.

[1] https://github.com/HypoPG/hypopg/tree/REL1_STABLE
[2] https://github.com/HypoPG/hypopg/tree/master
--
Best regards,
Yuzuko Hosoya
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2021-05-12 07:51:26 Re: compute_query_id and pg_stat_statements
Previous Message Julien Rouhaud 2021-05-12 07:13:39 Re: compute_query_id and pg_stat_statements