| From: | Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Adding support for SSLKEYLOGFILE in the frontend |
| Date: | 2025-02-20 03:36:26 |
| Message-ID: | CAKiP-K_0HV+Vte1CqGMtJErt7yB-1hwu9wF4+wef0QeSCqhO4Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
Please find attached a new version of this patch. I rebased on master,
added better error reporting and skipped the permissions check on
windows. Please let me know if this needs any changes. I tested this
locally using meson running all TAP tests.
Thanks
On Fri, Jan 10, 2025 at 5:16 PM Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com> wrote:
>
> Thanks, Daniel. Here is an updated patch with all previous changes,
> added a simple connection test and another check to make sure file
> mode is correct, and the env var fix. Please let me know if anything
> needs to be changed. I tested this locally using meson running all TAP
> tests, and also manually.
>
> Thanks
> Abhishek
>
> On Fri, Jan 10, 2025 at 9:29 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> >
> > > On 10 Jan 2025, at 04:59, Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com> wrote:
> >
> > Thanks for the new version.
> >
> > + {"sslkeylogfile", "SSLKEYLOGFILE",
> > The env var should be PGSSLKEYLOGFILE with the PG prefix.
> >
> > > 3. Added docs and tests
> >
> > There is no test in the attached patch, did you write one but forgot to git add
> > it before committing locally?
> >
> > --
> > Daniel Gustafsson
> >
>
>
> --
> Thanks and regards
> Abhishek Chanda
--
Thanks and regards
Abhishek Chanda
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Add-support-for-dumping-SSL-keylog-to-a-file.patch | application/octet-stream | 8.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-02-20 04:08:05 | RE: Proposal: Filter irrelevant change before reassemble transactions during logical decoding |
| Previous Message | Ajin Cherian | 2025-02-20 02:51:51 | Re: Proposal: Filter irrelevant change before reassemble transactions during logical decoding |