| From: | Kevin Burke <kevin(at)burke(dot)dev> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Better context for "TAP tests not enabled" error message |
| Date: | 2021-10-02 22:38:55 |
| Message-ID: | CAKcy5ej=7_37Fk8hHzjeyK9kKCw3FSp_TD-N_KaARgrX+H_gGg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Updated patch that removes the "Maybe"
--
Kevin Burke
phone: 925-271-7005 | kevin.burke.dev
On Sat, Oct 2, 2021 at 11:19 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> >> On 2 Oct 2021, at 02:09, Kevin Burke <kevin(at)burke(dot)dev> wrote:
> >> This patch amends the error message to give help to the user.
>
> > I think this makes sense,
>
> +1. I'd take out the "Maybe"; the diagnosis seems pretty certain.
>
> regards, tom lane
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Makefile-provide-better-help-if-TAP-tests-are-not-en.patch | application/octet-stream | 946 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-10-02 22:50:02 | Re: 002_types.pl fails on some timezones on windows |
| Previous Message | Tom Lane | 2021-10-02 22:26:35 | Re: 002_types.pl fails on some timezones on windows |