From: | Shubham Agarwal <shubham(dot)agarwal(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin][RM5410] Package Body is not being removed |
Date: | 2020-04-23 11:36:58 |
Message-ID: | CAKbCA9SY08j+tPEiDTvFiSUryQde7o9AeKXfJxSWp5ULvB9A+A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Patch looks good to me.
Please go ahead and commit the code.
On Thu, Apr 23, 2020 at 4:25 PM Shubham Agarwal <
shubham(dot)agarwal(at)enterprisedb(dot)com> wrote:
> I will be reviewing this patch.
>
> On Thu, Apr 23, 2020 at 3:30 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers
>>
>> RM #5410 has been reopened. *Problem Statement*: When we change the
>> definition of the package header it will delete the existing package body.
>> I confirmed that this is the expected behavior in the EDB Postgres Advanced
>> Server.
>>
>> Attached is the patch to just popped up the warning message for the user
>> before saving it.
>> *Note*: Warning message will be displayed only when the package header
>> is changed if we change the package body then no need to popped up the
>> warning message.
>>
>> Please review it.
>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Shubham Agarwal
> EnterpriseDB Corporation
>
> The Postgres Database Company
>
--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation
The Postgres Database Company
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2020-04-23 12:01:58 | pgAdmin 4 commit: Ensure all object types have a System XXX? property. |
Previous Message | Aditya Toshniwal | 2020-04-23 11:33:31 | [pgAdmin][RM1257] Ensure all object types have a "System XXX?" property |