Re: Fixes for pgAdmin feature tests

From: Shubham Agarwal <shubham(dot)agarwal(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Fixes for pgAdmin feature tests
Date: 2019-11-20 07:03:55
Message-ID: CAKbCA9RyJzhmTW_7dMiSgMumjDx3tXQ3aJT2nHYeuT9FKJpO7A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Team,
PFA feature test fixture patch containing the following things:

1. Added an attribute 'data-click-counter' in query execute button which
gets incremented once query button is clicked up to 9 and then reset to 0.
This is added just to support automation.
2. Locator for login_group_role is added and used to expand tree.
3. Functions for enabling and disable auto_commit and auto_rollback are
made more precise.
4. Some scrolling problem is addressed in view_data_dml_query test.
5. Handled the stale element reference exception in query_tool_journey_test

Regards,
Shubham Agarwal

On Fri, Nov 15, 2019 at 6:03 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, patch applied
>
> On Fri, Nov 15, 2019 at 5:59 PM Shubham Agarwal <
> shubham(dot)agarwal(at)enterprisedb(dot)com> wrote:
>
>> Hi Team,
>>
>> PFA feature test fixture patch containing the following fixes:
>> 1. Process watcher loading logs fix
>> 2. Auto commit/rollback issue in query_tool_tests
>> 3. Fixed the scrolling issue while verifying values in a table.
>> 4. Modified some functions in pgadmin_page.py
>>
>> On Wed, Nov 13, 2019 at 11:19 AM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Tue, Nov 12, 2019 at 6:27 PM Shubham Agarwal <
>>> shubham(dot)agarwal(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Team,
>>>> PFA patch containing some more fixes for random feature test failures.
>>>>
>>>> Thanks and regards,
>>>> Shubham Agarwal
>>>>
>>>> On Mon, Nov 11, 2019 at 10:55 AM Akshay Joshi <
>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Thanks, patch applied with a minor change. Menu for 'Delete Drop'
>>>>> server has been changed to 'Remove Server' which causes all the test cases
>>>>> failing on my machine.
>>>>>
>>>>> On Mon, Nov 11, 2019 at 10:18 AM Shubham Agarwal <
>>>>> shubham(dot)agarwal(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Team,
>>>>>>
>>>>>> Attached is the patch containing fixes for the failed feature test
>>>>>> cases.
>>>>>> This patch contains-
>>>>>> 1. Newly created function for traversing the browser tree.
>>>>>> 2. Some synchronization issue fixes.
>>>>>> 3. Modified locators.
>>>>>> 4. Test cases fix for the recent commits.
>>>>>>
>>>>>> --
>>>>>> Thanks & Regards,
>>>>>> Shubham Agarwal
>>>>>> EnterpriseDB Corporation
>>>>>>
>>>>>> The Postgres Database Company
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>>
>>>>> *Sr. Software Architect*
>>>>> *EnterpriseDB Software India Private Limited*
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Shubham Agarwal
>>>> EnterpriseDB Corporation
>>>>
>>>> The Postgres Database Company
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Shubham Agarwal
>> EnterpriseDB Corporation
>>
>> The Postgres Database Company
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company

Attachment Content-Type Size
feature_test_fix_v4.patch application/octet-stream 15.9 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-11-20 07:38:12 pgAdmin 4 commit: Fix some more feature tests:
Previous Message Aditya Toshniwal 2019-11-20 06:28:57 Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme