| From: | Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com> |
|---|---|
| To: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Draft for basic NUMA observability |
| Date: | 2025-03-07 10:20:03 |
| Message-ID: | CAKZiRmy-4ZuuZ+mYwcC+3-n46zy90vqRxZcXShLzwsopx5j50A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Wed, Mar 5, 2025 at 10:30 AM Jakub Wartak
<jakub(dot)wartak(at)enterprisedb(dot)com> wrote:
>Hi,
> > Yeah, that's why I was mentioning to use a "shared" populate_buffercache_entry()
> > or such function: to put the "duplicated" code in it and then use this
> > shared function in pg_buffercache_pages() and in the new numa related one.
>
> OK, so hastily attempted that in 7b , I had to do a larger refactor
> there to avoid code duplication between those two. I don't know which
> attempt is better though (7 vs 7b)..
>
I'm attaching basically the earlier stuff (v7b) as v8 with the
following minor changes:
- docs are included
- changed int8 to int4 in one function definition for numa_zone_id
-J.
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0002-Extend-pg_buffercache-with-new-view-pg_buffercach.patch | application/octet-stream | 29.5 KB |
| v8-0003-Add-pg_shmem_numa_allocations-to-show-NUMA-zones-.patch | application/octet-stream | 14.0 KB |
| v8-0001-Add-optional-dependency-to-libnuma-Linux-only-for.patch | application/octet-stream | 15.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jakub Wartak | 2025-03-07 10:21:09 | Re: AIO v2.5 |
| Previous Message | Dean Rasheed | 2025-03-07 10:08:41 | Re: [PATCH] Add get_bytes() and set_bytes() functions |