Re: PATCH: Choose best width for Data Output columns of Query tool

Hello,

Thanks for fixing this case as per my previous comments.

Could you also check one more case with the latest submitted patch.

Do
SELECT '1', 'f'; ==> And then re-size the 1st column to the end of the
screen.

Then do,
SELECT 'f', '111111......Wide column' ==> This should re-size the grid as
per the query result, which is not happening currently in my windows
machine.

*Note: Yours 1st patch is working fine with the above case.*

Thanks for your time and excellent support.

Dinesh

--
*Dinesh Kumar*
Software Engineer

Ph: +918087463317
Skype ID: dinesh.kumar432
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>

*Follow us on Twitter*
@EnterpriseDB

Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community> and
more <http://www.enterprisedb.com/resources-community>

On Wed, Nov 20, 2013 at 12:06 PM, Dinesh Kumar <
dinesh(dot)kumar(at)enterprisedb(dot)com> wrote:

> Thanks for fixing.
>
> Let me look into this.
>
> Dinesh
>
> --
> *Dinesh Kumar*
> Software Engineer
>
> Ph: +918087463317
> Skype ID: dinesh.kumar432
> www.enterprisedb.co <http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
>
> *Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, whitepapers<http://www.enterprisedb.com/resources-community> and
> more <http://www.enterprisedb.com/resources-community>
>
>
> On Tue, Nov 19, 2013 at 10:49 PM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:
>
>> Hello Dinesh,
>>
>> DK> Could you check the following thing in your development machine.
>> >>> After applying your patch, i am not able to re-size the grid
>> >>> columns in windows 7 (64-bit) machine.
>> That possibly was a wide column that didn't want to shorten?
>> Ok, I changed AutoSizeColumns(bool setAsMin = true) to false.
>>
>> DP> please check it retains the column sizes following refresh if the
>> DP> user has customised them,
>> I missed this, but now it should work as it did before.
>>
>> DP> I would suggest that a column should never take up more than 50%
>> DP> of the visible space, unless that space would otherwise be unused
>> That's exactly what is done :)
>>
>> Please see the modified patch attached.
>> Thanks.
>>
>>
>>
>>
>>
>>
>>
>> Tuesday, November 19, 2013, 4:35:05 PM, you wrote:
>>
>> DK> On Tue, Nov 19, 2013 at 2:38 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> DK> Dinesh, can you review this please? In particular, please check it
>> DK> retains the column sizes following refresh if the user has customised
>> DK> them, and that it puts a limit on the size of very long columns so the
>> DK> user doesn't potentially end up with extremely wide columns that
>> DK> require excessive scrolling (I would suggest that a column should
>> DK> never take up more than 50% of the visible space, unless that space
>> DK> would otherwise be unused (e.g. you have 1 very narrow column, and one
>> DK> large).
>>
>> DK> Thanks.
>>
>> DK> On Sun, Nov 17, 2013 at 6:41 PM, J.F. Oster <jinfroster(at)mail(dot)ru>
>> wrote:
>> >> Hi All,
>> >>
>> >> Please see the attached patch.
>> >> It makes use of wxGrid's AutoSizeColumns() and applies some reasonable
>> >> limits afterwards. Works nicely in most scenarios I could imagine.
>> >> Tested with wxWidgets 2.8.12 on Ubuntu Linux.
>> >>
>> >> Possibly this code should be moved to some procedure and triggered
>> >> from on-resize event handler as well?
>> >> Also it would be nice to have same behavior in "Edit Data" window
>> >> (ctlSQLEditGrid). But I'm new to wxWidgets... so please let me know
>> >> how to implement that better.
>> >> Thanks!
>> >>
>> >>
>> >> P.S. My company is moving from Oracle and a perfect IDE called "PL/SQL
>> >> Developer" (by allroundautomations.com) to PostgreSQL and pgAdmin III.
>> >> Having used pgAdmin years before, I see it gaining functionality to
>> >> support fast-growing PostgreSQL's features (great job!) but not
>> >> usability that well. Hope I can work on that (as far as I can :))
>>
>> --
>> Best regards,
>> Vadim
>>
>
>