Re: [PATCH] avoid buffer underflow in errfinish()

From: Xi Wang <xi(dot)wang(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] avoid buffer underflow in errfinish()
Date: 2013-03-27 21:58:04
Message-ID: CAKU6vyb7RmYKcWU1r830x0861-5OQAuhKuS5GsPez44wD5hViw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 27, 2013 at 9:03 AM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> Writing it like that suggests that autovac might sometimes be NULL, even if
> deadlock_state == DS_BLOCKED_BY_AUTOVACUUM. From your explanation above, I
> gather that's not possible (and I think you're right), so the NULL check is
> unnecessary. If we think it might be NULL after all, the above makes sense.

That makes sense. Thanks for the clarification!

- xi

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2013-03-27 22:25:35 Re: plpgsql_check_function - rebase for 9.3
Previous Message Simon Riggs 2013-03-27 21:42:08 Re: Catching resource leaks during WAL replay