Re: A minor adjustment to get_cheapest_path_for_pathkeys

From: Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com>
Subject: Re: A minor adjustment to get_cheapest_path_for_pathkeys
Date: 2023-09-06 07:13:39
Message-ID: CAKU4AWrnX6rjPkysb+Cfdd8HdKPFEg_-9z5pdsqY3uwCRYxM1g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> I guess the *valuable* sometimes means the effort we pay is greater
> than the benefit we get, As for this patch, the benefit is not huge (it
> is possible the compiler already does that). and the most effort we pay
> should be committer's attention, who needs to grab the patch, write the
> correct commit and credit to the author and push it. I'm not sure if
> Aleksander is worrying that this kind of patch will grab too much of
> the committer's attention and I do see there are lots of patches like
> this.
>

I forget to mention that the past contribution of the author should be a
factor as well. Like Richard has provided lots of performance improvement,
bug fix, code reviews, so I believe more attention from committers should
be a reasonable request.

--
Best Regards
Andy Fan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Quan Zongliang 2023-09-06 07:50:37 Re: Improving the heapgetpage function improves performance in common scenarios
Previous Message Andy Fan 2023-09-06 07:00:00 Re: Extract numeric filed in JSONB more effectively