| From: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Floris Van Nee <florisvannee(at)optiver(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "rushabh(dot)lathia(at)gmail(dot)com" <rushabh(dot)lathia(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Keeps tracking the uniqueness with UniqueKey |
| Date: | 2020-09-08 23:51:12 |
| Message-ID: | CAKU4AWoN8fJrZ=8b_6iCWF6rvxn_bx46D6Q_gRucJYOhRvSdKQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 7, 2020 at 3:22 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Tue, Aug 04, 2020 at 06:59:50AM +0800, Andy Fan wrote:
> > You are correct, I would include this in the next version patch, Thank
> you
> > for this checking!
>
> Regression tests are failing with this patch set applied. The CF bot
> says so, and I can reproduce that locally as well. Could you look at
> that please? I have switched the patch to "waiting on author".
> --
> Michael
>
Thank you Michael for checking it, I can reproduce the same locally after
rebasing to the latest master. The attached v11 has fixed it and includes
the fix Floris found.
The status of this patch is we are still in discussion about which data
type should
UniqueKey->expr use. Both David [1] and I [2] shared some thinking about
EquivalenceClasses, but neither of us have decided on it. So I still didn't
change
anything about that now. I can change it once we have decided on it.
--
Best Regards
Andy Fan
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0002-Introduce-UniqueKey-attributes-on-RelOptInfo-str.patch | application/octet-stream | 58.6 KB |
| v11-0005-Treat-the-input-as-sorted-if-the-group-by-clause.patch | application/octet-stream | 13.2 KB |
| v11-0003-Refactoring-existing-uniqueness-related-code-to-.patch | application/octet-stream | 19.2 KB |
| v11-0001-Introduce-RelOptInfo-notnullattrs-attribute.patch | application/octet-stream | 4.8 KB |
| v11-0004-Remove-distinct-node-AggNode-if-the-input-is-uni.patch | application/octet-stream | 25.7 KB |
| v11-0006-Join-removal-at-run-time-with-UniqueKey.patch | application/octet-stream | 14.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2020-09-09 00:02:38 | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |
| Previous Message | Justin Pryzby | 2020-09-08 23:39:51 | Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly |