Re: [PATCH] add option to pg_dumpall to exclude tables from the dump

From: Gerdan Rezende dos Santos <gerdan(at)gmail(dot)com>
To: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Juergen Hannappel <juergen(at)juergen-hannappel(dot)de>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] add option to pg_dumpall to exclude tables from the dump
Date: 2016-09-07 01:37:47
Message-ID: CAKOcMA6yi6P1ZLLqi1=VC3d4Xo9FiiZOMuRe1-ieUPgQ2X-n_w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 19, 2016 at 12:38 PM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
wrote:

> On 8/18/16 5:01 PM, Tom Lane wrote:
>
>> I agree, but I think mandating a database name (which I suppose could be
>>> > *) with the specifiers would solve that issue.
>>>
>> Hmm, something like "-T dbname1:pattern1 -T dbname2:pattern2" ?
>>
>
> Bingo. Hopefully there'd be some way to consolidate the code between the
> two as well...
> --
> Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
> Experts in Analytics, Data Architecture and PostgreSQL
> Data in Trouble? Get it in Treble! http://BlueTreble.com
> 855-TREBLE2 (855-873-2532) mobile: 512-569-9461
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

After review, I realized that there is a call to the function:
doShellQuoting (pgdumpopts, OPTARG), which no longer seems to exist ...
After understand the code, I saw that the call is appendShellString (
pgdumpopts, OPTARG).

Follow the patches already with the necessary corrections.

Regards
*Gerdan Rezende dos Santos *
*Po*stgreSQL & EnterpriseDB Specialist, Support, Training & Services
+55 (61) 9645-1525

Attachment Content-Type Size
pg_dumpall.c text/x-csrc 1.6 KB
pg_dumpall.sgml text/sgml 994 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2016-09-07 01:38:19 Re: ICU integration
Previous Message Peter Geoghegan 2016-09-07 01:30:59 Re: ICU integration