| From: | Artur Zakirov <zaartur(at)gmail(dot)com> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, nagata(at)sraoss(dot)co(dot)jp |
| Subject: | Re: Checking MINIMUM_VERSION_FOR_WAL_SUMMARIES |
| Date: | 2024-02-02 09:11:34 |
| Message-ID: | CAKNkYnzO4SAr-8Ja9YUgCteHPYWsRdJk6w4aXp7ziao7Ms4hhw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2 Feb 2024 at 09:41, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> wrote:
> You seem right, nice catch. Also, this change makes the check in
>
> snprintf(summarydir, sizeof(summarydir), "%s/%s/summaries",
> basedir,
> PQserverVersion(conn) < MINIMUM_VERSION_FOR_PG_WAL ?
> "pg_xlog" : "pg_wal");
>
> redundant. PQserverVersion(conn) will always be higher than
> MINIMUM_VERSION_FOR_PG_WAL.
Thank you both for the comments. Indeed, that part now looks redundant.
I've attached a patch to remove checking MINIMUM_VERSION_FOR_PG_WAL.
--
Artur
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-checking-MINIMUM_VERSION_FOR_WAL_SUMMARIES-fo.patch | text/x-patch | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2024-02-02 09:18:59 | Re: Check lateral references within PHVs for memoize cache keys |
| Previous Message | Alexander Lakhin | 2024-02-02 09:00:00 | Re: ResourceOwner refactoring |