| From: | Artur Zakirov <zaartur(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Subject: | Re: Added schema level support for publication. |
| Date: | 2024-12-16 11:51:20 |
| Message-ID: | CAKNkYnyZV5Bz+=y6emiWJ3RfcGoSFTFKp8VwC44_75xKGTztLg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, 16 Dec 2024 at 12:05, vignesh C <vignesh21(at)gmail(dot)com> wrote:
> I prefer the other approach to remove both the checks in
> getPublicationTables() and getPublicationNamespaces() which also makes
> it consistent with the other case that Amit mentioned at [1].
If I understand your suggestion correctly I think this will break the
"--exclude-schema" option of pg_dump. That change will dump all
mappings between publications and schemas for publications which are
dumped.
That solves the issue with special schemas, but restore will fail if
some schemas were explicitly excluded. pg_dump will include in the
dump ALTER PUBLICATION <pub> ADD TABLES IN SCHEMA <schema> even for
those schemas which are not created during restore.
I think getPublicationNamespaces() should handle both special schemas
and excluded schemas, which can make the code a bit more complex
though.
--
Kind regards,
Artur
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junwang Zhao | 2024-12-16 12:00:30 | Re: SQL Property Graph Queries (SQL/PGQ) |
| Previous Message | Nishant Sharma | 2024-12-16 11:50:24 | Re: on_error table, saving error info to a table |