Re: [HACKERS] Re: [PATCH] Tab completion for ALTER TYPE … RENAME VALUE …

From: Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>
Subject: Re: [HACKERS] Re: [PATCH] Tab completion for ALTER TYPE … RENAME VALUE …
Date: 2016-11-06 17:48:18
Message-ID: CAKNkYnw8wVX5htytcQ8LGOuYY4kBbq7F4L5qsDOMkH6jm6-SsQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

2016-09-12 16:16 GMT+03:00 Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>:
>
> I've added it to the 2016-11 commit fest:
> https://commitfest.postgresql.org/11/795/
>
> - ilmari

I've tested your patch.

Patch was applied to the master. It seems there is no need to rebase
it. PostgreSQL was compiled without errors with the patch.

I've tested the patch with type:

CREATE TYPE rainbow AS ENUM ('red', 'orange', 'yellow', 'green',
'blue', 'purple');

And the following completions work as expected:

=> ALTER TYPE rainbow RENAME <tab>
ATTRIBUTE TO VALUE

=> ALTER TYPE rainbow RENAME VALUE <tab>
'blue' 'green' 'orange' 'purple' 'red' 'yellow'

It seems that the patch can be commited without any fixes. So I marked
it as "Ready for Committer".

--
Sincerely,
Artur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-11-06 18:15:28 Re: Add support for SRF and returning composites to pl/tcl
Previous Message Artur Zakirov 2016-11-06 15:26:57 Re: Bug in to_timestamp().