From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Control for displaying "auto vacuum" fields into grid |
Date: | 2016-04-07 10:49:32 |
Message-ID: | CAKKotZTyq5xQmLjLQm4jetsUA2qKg0OcX+Md=WX9Kzzrup2rdA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi,
Rebase patch and sent again.
Regrds,
Murtuza
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Thu, Apr 7, 2016 at 4:07 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find updated patch, I have moved everything at schema level and
> tweak some code as well, so that we can use it in Table/View node.
>
>
> Regards,
> Murtuza
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Mar 25, 2016 at 4:50 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi Surinder,
>>
>> Can you please move all genereic logic & sql at schema level so that we
>> can use it in table node as well?
>> Currently it’s materialized view node centric only.
>>
>>
>> Regards,
>> Murtuza
>>
>>
>> On 23-Mar-2016, at 9:34 pm, Surinder Kumar <
>> surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>
>> Hi,
>>
>>
>> On Fri, Mar 18, 2016 at 8:58 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> On Fri, Mar 18, 2016 at 10:37 AM, Surinder Kumar
>>> <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>>> > Hi,
>>> >
>>> > PFA control for displaying auto vacuum fields into grid. This control
>>> is
>>> > common for
>>> > Materialized View Node and Table Node.
>>> >
>>> > Usage:
>>> >
>>> > {
>>> > id: 'vacuum_table', label: '{{ _("Vacuum Table") }}',
>>> > model: VacuumTableModel, editable: false, type: 'collection',
>>> > canEdit: true, group: '{{ _("Table") }}',
>>> > mode: ['edit', 'create'], url: 'get_vacuum_defaults',
>>> > control: Backform.VacuumCollectionControl.extend({
>>> > grid_columns :[
>>> > {
>>> > name: 'label', label: '{{ _("Label") }}',
>>> > cell: 'string', editable: false
>>> > },
>>> > {
>>> > name: 'value', label: '{{ _("Value") }}',
>>> > cellFunction: cellFunction, editable: function(m) {
>>> > if(m.handler.has('autovacuum_enabled')) {
>>> > return m.handler.get('autovacuum_enabled');
>>> > }
>>> > return !m.handler.isNew();
>>> > }
>>> > },
>>> > {
>>> > name: 'setting', label: '{{ _("Default value") }}',
>>> > cellFunction: cellFunction, editable: false
>>> > }
>>> > ]
>>> > }),
>>> >
>>> >
>>> > When using this control, provide following parameters in schema:
>>> > 1. model
>>> > 2. url - to fetch default values for auto vacuum fields.
>>> > 3. grid columns - Name of the columns to display in the grid.
>>> >
>>> >
>>> > Please review the patch.
>>>
>>> It's hard to review this without being able to test. Do you have a
>>> simple test case?
>>>
>>
>> I have submitted patch for materialized view which is using this control.
>> so you can test it in materialized view.
>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>
Attachment | Content-Type | Size |
---|---|---|
Updated_VaccumSettings_Control_v1.patch | application/octet-stream | 15.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Page | 2016-04-07 11:27:39 | pgAdmin 4 commit: Fix sub-node error display. |
Previous Message | Murtuza Zabuawala | 2016-04-07 10:37:15 | Re: Control for displaying "auto vacuum" fields into grid |