Re: PATCH: To fix the issue where cast function causes freeze (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix the issue where cast function causes freeze (pgAdmin4)
Date: 2016-07-15 11:44:16
Message-ID: CAKKotZTZfw2MtV93nD34grAFiT+0_fCsNFSBvYrKfZ0f225eeA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Yes, I am aware of that, but the issue you mentioned is due to psycopg2
DictCursor issue which I have already mentioned earlier (RM#1409)
https://github.com/psycopg/psycopg2/issues/454.

The patch is for different issue (RM#1438).

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jul 15, 2016 at 4:37 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> On Thu, Jul 14, 2016 at 10:06 AM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA patch to fix the issue where if user use cast function and it causes
> > freeze in query tool.
> > (RM#1438)
>
> This fixes the hang, but then displays the wrong data type for the
> first column - e.g.
>
> SELECT CURRENT_TIMESTAMP, CAST ( CURRENT_TIMESTAMP AS text ) ;
>
> will show the columns as "now text(8)" and "now text", when it should
> be "now timestamp with time zone", "now text"
>
> Note that SELECT CURRENT_TIMESTAMP also gets this a little wrong - it
> shows "now timestamp with time zone(8)" (the size shouldn't be
> included)
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Murtuza Zabuawala 2016-07-15 11:49:35 Re: PATCH: To fix the issue where cast function causes freeze (pgAdmin4)
Previous Message Dave Page 2016-07-15 11:14:21 Re: PATCH: security label is not being added/updated for MATERIALIZED VIEW