Re: PATCH: To fix salt generation in session.py

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix salt generation in session.py
Date: 2016-07-11 07:14:20
Message-ID: CAKKotZT058JHVyc=Avsz_S4f=QzoTMnQAWNXsXEm3W1BgmnGfw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please hold on in this patch, Need additional changes.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> With latest pull session.py fails with below error with python3 because in
> python3 strings 'lowercase' method has been renamed to 'ascii_lowercase',
> PFA patch to fix the issue.
>
> Issue:
> ----------
> * File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign*
> * self.randval = ''.join(random.sample(string.lowercase+string.digits,
> 20))*
> *AttributeError: module 'string' has no attribute 'lowercase'*
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2016-07-11 08:13:45 [pgAdmin4][Patch]: Clear query window button click opens query tool in new window in Mac Runtime
Previous Message Murtuza Zabuawala 2016-07-11 07:11:56 PATCH: To fix salt generation in session.py