Re: Quick search for menu items & help articles

Hello,

On Tue, Feb 2, 2021 at 2:49 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Thanks, patch applied with some string modifications.
>

Co-author name is missing from the commit message,

The feature is implemented in two parts,
Frontend: Pramod
Backend: Murtuza (As mentioned by Pramod in the previous email)

Thanks,
Murtuza

>
> On Mon, Feb 1, 2021 at 1:32 PM Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
> wrote:
>
>> Hi Akshay,
>>
>>
>>
>> Please find the rebased patch as attached with this email.
>>
>>
>>
>> Please do let me know if need anything else.
>>
>>
>>
>> *Pramod Ahire*
>>
>> *Software Engineer*
>>
>>
>>
>> [image:
>> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMPtrrxcUwEHZgbGJC4R0qR4r1sBZa_z9R8ihFRaP2Hr_Wnhq6HcIQHe1ZoviDPwUkTdzNcg]
>>
>>
>>
>> C: +91-020-66449600/601
>>
>> D: +91-9028697679
>>
>> *edbpostgres.com <http://edbpostgres.com>*
>>
>>
>>
>>
>>
>> *From: *Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
>> *Date: *Monday, 25 January 2021 at 3:53 PM
>> *To: *Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
>> *Cc: *Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <
>> pgadmin-hackers(at)postgresql(dot)org>
>> *Subject: *Re: Quick search for menu items & help articles
>>
>>
>>
>> Hi Pramod
>>
>>
>>
>> The patch is not applied, maybe you need to rebase and send the patch
>> again.
>>
>>
>>
>> On Wed, Jan 20, 2021 at 4:36 PM Pramod Ahire <
>> pramod(dot)ahire(at)enterprisedb(dot)com> wrote:
>>
>> Hi Team,
>>
>>
>>
>> Sorry for the inconvenience, kindly please discard previous email.
>>
>>
>>
>> Please review patch attached to this email.
>>
>> Changes as below :
>>
>> 1. Added complete quick search menu to help dropdown
>> 2. Added message to each disabled menu item to describe why it can be
>> disabled
>>
>> 3. Info icon design to menu items results if disabled
>> 4. Standard/dark/high contrast theme supports
>>
>> NOTE: “Initial backend search mechanism patch by: Murtuza Zabuawala”
>>
>>
>>
>> Thanks !
>>
>>
>>
>> *Pramod Ahire*
>>
>> *Software Engineer*
>>
>>
>>
>> [image:
>> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMPtrrxcUwEHZgbGJC4R0qR4r1sBZa_z9R8ihFRaP2Hr_Wnhq6HcIQHe1ZoviDPwUkTdzNcg]
>>
>>
>>
>> C: +91-020-66449600/601
>>
>> D: +91-9028697679
>>
>> *edbpostgres.com <http://edbpostgres.com>*
>>
>>
>>
>>
>>
>> *From: *Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
>> *Date: *Wednesday, 20 January 2021 at 4:19 PM
>> *To: *Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, Dave Page <
>> dpage(at)pgadmin(dot)org>
>> *Cc: *pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
>> *Subject: *Re: Quick search for menu items & help articles
>>
>>
>>
>> Hi Team,
>>
>>
>>
>> As per inputs from you all, made changes & attached patch with this email.
>>
>>
>>
>> Kindly please have a review & do let me know if missed anything.
>>
>>
>>
>> Thanks !
>>
>>
>>
>> *Pramod Ahire*
>>
>> *Software Engineer*
>>
>>
>>
>> [image:
>> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMPtrrxcUwEHZgbGJC4R0qR4r1sBZa_z9R8ihFRaP2Hr_Wnhq6HcIQHe1ZoviDPwUkTdzNcg]
>>
>>
>>
>> C: +91-020-66449600/601
>>
>> D: +91-9028697679
>>
>> *edbpostgres.com <http://edbpostgres.com>*
>>
>>
>>
>>
>>
>> *From: *Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
>> *Date: *Friday, 15 January 2021 at 3:34 PM
>> *To: *Dave Page <dpage(at)pgadmin(dot)org>
>> *Cc: *Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>, pgadmin-hackers <
>> pgadmin-hackers(at)postgresql(dot)org>
>> *Subject: *Re: Quick search for menu items & help articles
>>
>>
>>
>>
>>
>>
>>
>> On Fri, Jan 15, 2021 at 3:15 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>
>>
>>
>>
>> On Fri, Jan 15, 2021 at 9:43 AM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>> Hi Dave
>>
>>
>>
>> On Fri, Jan 15, 2021 at 2:46 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>> Hi
>>
>>
>>
>> On Fri, Jan 15, 2021 at 7:23 AM Pramod Ahire <
>> pramod(dot)ahire(at)enterprisedb(dot)com> wrote:
>>
>> Hi Dave,
>>
>>
>>
>> Thank you for comments ! I had described points below. Please do let me
>> know if anything missing.
>>
>>
>>
>> *From: *Dave Page <dpage(at)pgadmin(dot)org>
>> *Date: *Thursday, 14 January 2021 at 10:26 PM
>> *To: *Pramod Ahire <pramod(dot)ahire(at)enterprisedb(dot)com>
>> *Cc: *pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
>> *Subject: *Re: Quick search for menu items & help articles
>>
>>
>>
>> Hi
>>
>>
>>
>> On Thu, Jan 14, 2021 at 4:48 PM Pramod Ahire <
>> pramod(dot)ahire(at)enterprisedb(dot)com> wrote:
>>
>> Hi Team,
>>
>>
>>
>> Please find the attached designs & patch that contains complete
>> functionality except below to do for quick search.
>>
>>
>>
>> To Do:
>>
>>
>>
>> - Unit test cases are not that sufficient to cover complete code, but
>> will be working in background to cover up those one
>> - In pgadmin, for disabled menu items we need to add info that will
>> describe why menu has disabled & how it will be enabled. Either another way
>> to enable all of them & show respective reason in popup that menu is
>> disabled for.
>>
>>
>>
>> Please do let me know if I missed anything or suggestion of yours.
>>
>>
>>
>> Looks very good. I haven't done an extensive code review/test, but two
>> things spring to mind immediately:
>>
>>
>>
>> 1) I think the search box should be the top item on the Help menu. I do
>> not think it should be on the far end of the menu bar, as it looks too much
>> like it will search for data (think of search on a website).
>>
>>
>>
>> - As we are showing menu items as well in search results, it can be
>> redundant for end user & increase duplications of menu items. Please advise
>> your thoughts on this.
>>
>>
>>
>> The search box could be on the Help menu, with results shown in a
>> sub-menu under it.
>>
>>
>>
>> Another more simple option would be to move the search icon to be
>> directly after the Help menu (which would hint that it's related to the
>> menus), but I'm also concerned about the number of items on the top menu -
>> we're getting to the point that 'common' window sizes would show the
>> hamburger menu by default.
>>
>>
>>
>> I personally feel we should not add the search box on the Help menu,
>> it should be kept separate with a placeholder indicating what is it for. We
>> can move the search icon after the Help menu.
>>
>>
>>
>> What is your reasoning? It is, after all, specifically designed to help
>> people.
>>
>>
>>
>> OK, I have seen a couple of applications where the search box is
>> inside the Help menu, agree with your point.
>>
>>
>>
>>
>>
>>
>>
>> 2) Do we need another loading icon? Surely there's one in the source tree
>> already that we can use?
>>
>>
>>
>> - As we are loading help articles count in background, so I have added
>> background loading icon to show near to count of results. Our existing icon
>> is of blue & white circle combination, which will be more useful to show
>> foreground loading.
>>
>>
>>
>> Hmm, OK.
>>
>>
>>
>>
>>
>> Please do let me know your valuable inputs on this.
>>
>>
>>
>>
>>
>> *Pramod Ahire*
>>
>> *Software Engineer*
>>
>>
>>
>> [image:
>> https://lh4.googleusercontent.com/U1erEuyI_d0xEUA0CrKjwx9aWQ52HNCxc38dMsLP-ZrLgfVNrhsrNobxlmeOdb1kMPtrrxcUwEHZgbGJC4R0qR4r1sBZa_z9R8ihFRaP2Hr_Wnhq6HcIQHe1ZoviDPwUkTdzNcg]
>>
>>
>>
>> C: +91-020-66449600/601
>>
>> D: +91-9028697679
>>
>> *edbpostgres.com <http://edbpostgres.com>*
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> --
>>
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>>
>>
>> --
>>
>> *Thanks & Regards*
>>
>> *Akshay Joshi*
>>
>> *pgAdmin Hacker | Principal Software Architect*
>>
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>>
>>
>>
>> --
>>
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EDB: http://www.enterprisedb.com
>>
>>
>>
>>
>> --
>>
>> *Thanks & Regards*
>>
>> *Akshay Joshi*
>>
>> *pgAdmin Hacker | Principal Software Architect*
>>
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>>
>>
>>
>> --
>>
>> *Thanks & Regards*
>>
>> *Akshay Joshi*
>>
>> *pgAdmin Hacker | Principal Software Architect*
>>
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>