Re: [patch] Move to Alembic migration system

Hi,

PFA minor add-on patch for README.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Mar 31, 2017 at 8:04 PM, Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi Ashesh,
>
> Patch looks good to me.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Mar 31, 2017 at 1:10 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Joao & Sarah,
>>
>> I have asked Murtuza to review the patch today.
>> He will update me by EOD.
>>
>> If all goes well, I will commit the patch.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> <http://www.enterprisedb.com>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>> On Thu, Mar 30, 2017 at 8:36 PM, Joao Pedro De Almeida Pereira <
>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>
>>> Hello Dave and Ashesh,
>>>
>>> Do you still need us to provide more information about this patch or is
>>> it ready to be merged?
>>>
>>> Thanks
>>> Joao
>>>
>>> On Thu, Mar 23, 2017 at 12:00 PM, Joao Pedro De Almeida Pereira <
>>> jdealmeidapereira(at)pivotal(dot)io> wrote:
>>>
>>>> Hello Hackers,
>>>>
>>>> We found out a issue using Python 3 related to importing modules that
>>>> we corrected in the patch that is now attached.
>>>>
>>>> Also we would like to know the status of this.
>>>>
>>>> Thanks
>>>> Joao & Sarah
>>>>
>>>> On Fri, Mar 17, 2017 at 10:32 AM, Sarah McAlear <smcalear(at)pivotal(dot)io>
>>>> wrote:
>>>>
>>>>> Hi!
>>>>>
>>>>> We realized that this change was causing the tests to fail because the
>>>>> folder for the sqlite databases was not being created. We also updated the
>>>>> files to contain the missing headers.
>>>>>
>>>>> Thanks!
>>>>> Joao & Sarah
>>>>>
>>>>>
>>>>>
>>>>> On Thu, Mar 16, 2017 at 9:31 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>
>>>>>> Ashesh, can you review/commit this please? One thing I notice on a
>>>>>> quick look through is that the file headers are missing everywhere.
>>>>>> They should be present in all source files, except where they would
>>>>>> bloat the data transfer from client to server.
>>>>>>
>>>>>> On Wed, Mar 15, 2017 at 8:09 PM, Sarah McAlear <smcalear(at)pivotal(dot)io>
>>>>>> wrote:
>>>>>> > Hi Hackers!
>>>>>> >
>>>>>> > It looks like our previous patch messed up some logging. Please use
>>>>>> this one
>>>>>> > instead.
>>>>>> >
>>>>>> > Thanks,
>>>>>> > Joao & Sarah
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> > On Wed, Mar 15, 2017 at 2:46 PM, Sarah McAlear <smcalear(at)pivotal(dot)io>
>>>>>> wrote:
>>>>>> >>
>>>>>> >> Hi Hackers!
>>>>>> >>
>>>>>> >> Here's a patch to move to current db migration system to use
>>>>>> Alembic.
>>>>>> >> Instructions to create new migrations are in the README.
>>>>>> >>
>>>>>> >> Thanks!
>>>>>> >> Joao & Sarah
>>>>>> >>
>>>>>> >
>>>>>> >
>>>>>> >
>>>>>> > --
>>>>>> > Sent via pgadmin-hackers mailing list (
>>>>>> pgadmin-hackers(at)postgresql(dot)org)
>>>>>> > To make changes to your subscription:
>>>>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>> >
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Dave Page
>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>> Twitter: @pgsnake
>>>>>>
>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>> The Enterprise PostgreSQL Company
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>