From: | Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: PATCH: Added Statistics functionality for many nodes (pgAdmin4) |
Date: | 2016-06-08 05:54:55 |
Message-ID: | CAKKotZSn3mjmLNnBVY3EX3dy8XSOLtEgdg=P1Efsc8m1krvTLw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave,
Can you please share steps to re-produce RM#1316, I’m not able to
re-produce it on my side.
Meanwhile, PFA patch for RM#1315 :-)
Regards,
Murtuza
On 07-Jun-2016, at 5:52 pm, Dave Page <dpage(at)pgadmin(dot)org> wrote:
Thanks. I've pushed this with changes to reformat some of the SQL, and
ensure the column headers are properly cased.
There is one outstanding bug though - if an object is selected for
which the stats query doesn't return any rows (e.g. track_functions =
false), then weird things happen - you get an empty error message, or
the previous stats might be re-shown. Please fix the patch so that in
such cases the pgAdmin 3 behaviour is followed, i.e. the table header
is shown, but no rows (bug #1316).
Also, please look at #1315 which you're at it :-)
Thanks again.
On Tue, Jun 7, 2016 at 12:27 PM, Murtuza Zabuawala
<murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
Hi,
PFA patch to add Statistics functionality to below nodes,
Table
Function
Procedure
Trigger Function
Sequence
Index
Column
Primary Key
Unique constraint
Exclusion constraint
(RM#1299)
---------------
Additionally, attaching two separate patches,
1) To update validation of object before using it
(file: statistics.js)
2) To fix incorrect condition checking for privileges.
Thanks to Surinder for reporting this issue.
(file: privilege.js)
Please review.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
RM_1315.patch | application/octet-stream | 740 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2016-06-08 06:16:53 | Re: PATCH: Added Statistics functionality for many nodes (pgAdmin4) |
Previous Message | Colin Beckingham | 2016-06-07 17:38:53 | pgadmin4 install problems |