Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
Date: 2018-02-27 11:59:53
Message-ID: CAKKotZSbDqjKKNaprnXM7eEW3wR1ffbDbmmh2B-xqtybUVv_Bw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Could you please send screenshot?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Feb 27, 2018 at 5:24 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> Still not quite right - see the attached screenshot which is the result of
> simply viewing the properties of an existing job. Note that the start time
> is shown in the grid but not the subnode control.
>
> Thanks.
>
> On Tue, Feb 27, 2018 at 8:26 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> As validation related patch was committed with RM#3148 [ Sorry about that
>> I forgot to checkout :) ]
>> PFA patch to fix the issues you mentioned, I have also removed extra
>> error message from sub node collection control and made it optional via
>> flag.
>>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> On Mon, Feb 26, 2018 at 10:14 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Mon, Feb 26, 2018 at 2:46 PM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> PFA patch to fix the issue where user was not able to create pgAgent
>>>> job from UI without entering End date in schedule section.
>>>>
>>>
>>> Whilst this does resolve the validation issue, there are still a couple
>>> of other related problems, as can be seen in the attached screenshots:
>>>
>>> - The Start date/time in the subnode control doesn't seem to be properly
>>> synchronised with the value in the grid.
>>>
>>> - If you leave the End date/time blank (but maybe click into it first),
>>> the grid will show "Invalid date".
>>>
>>> It's possible there are other oddities as well - please check carefully
>>> for anything else.
>>>
>>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-02-27 12:00:57 Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI
Previous Message Dave Page 2018-02-27 11:54:54 Re: [pgAdmin4][RM#3073] Allow user to schedule without End date from UI