Re: PATCH: To fix issue in synonym node (pgAdmin4)

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: To fix issue in synonym node (pgAdmin4)
Date: 2016-10-05 12:28:11
Message-ID: CAKKotZSayUMYQgQh-An0FnL7hA_U7ybhfDsJYr=nEMMKw03v5A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

PFA updated patch, Added schema filter in sql.
Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Oct 5, 2016 at 5:38 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA patch to fix the issue in synonym node, where it was not horning
> parent
> > node while creating in different node, issue was that we were not sending
> > node properly.
> > RM#1611
>
> That doesn't seem like a reliable way to get the correct parent ID -
> what if there are multiple synonyms in different schemas but with the
> same name?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
RM_1611_v1.patch application/octet-stream 3.6 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Olav Peeters 2016-10-05 12:37:47 Re: pgadmin4 RPMs need some testing!
Previous Message Murtuza Zabuawala 2016-10-05 12:09:08 Re: PATCH: To fix the issue in Debugger module (pgAdmin4)