Re: [pgAdmin4][RM#3272] - Replace the pycrypto with the pycryptodome

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
Cc: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][RM#3272] - Replace the pycrypto with the pycryptodome
Date: 2018-04-23 06:35:58
Message-ID: CAKKotZSL6hT_3J3PP3vQz_2fsqbWHTHE_2AFYK8yTAaEjr++OQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Aditya,

Have you tested the changes with runtime?
It was only causing issue in runtime otherwise it was working fine with web
mode.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Apr 18, 2018 at 7:51 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:

> Hi Aditya,
> Didn't we revert a patch that added pycryptodome due to problem in
> problems on windows? Is it solved now?
>
> Thanks
> Joao
>
> On Wed, Apr 18, 2018 at 7:23 AM Aditya Toshniwal <aditya.toshniwal@
> enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> PFA patch for replacing pycrytpo with pycryptodome.
>> Tested on Postgres 9.6,10 - Windows, Linux.
>>
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Software Engineer | EnterpriseDB Software Solutions
>> Pune | Mob - 8055837949 <(805)%20583-7949>
>>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2018-04-23 06:49:52 Re: [pgAdmin4][RM#3272] - Replace the pycrypto with the pycryptodome
Previous Message Dave Page 2018-04-20 08:47:08 pgAdmin 4 commit: Another attempt at making the JA translation work pro