Re: PATCH: To fix issue in synonym node (pgAdmin4)

Hi Dave,

The issue you mentioned is different issue and not related to synonyms node.
I will create separate ticket & work on it mean while you can commit
changes for RM#1611

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Oct 5, 2016 at 6:53 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> I created a synonym from within the "dave" schema, but selected
> "public" (which wasn't expanded), and it placed the synonym as a
> direct child of "public". See the attached screenshot.
>
> On Wed, Oct 5, 2016 at 1:28 PM, Murtuza Zabuawala
> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> > Hi Dave,
> >
> > PFA updated patch, Added schema filter in sql.
> > Please review.
> >
> > --
> > Regards,
> > Murtuza Zabuawala
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> > On Wed, Oct 5, 2016 at 5:38 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>
> >> Hi
> >>
> >> On Wed, Oct 5, 2016 at 9:53 AM, Murtuza Zabuawala
> >> <murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
> >> > Hi,
> >> >
> >> > PFA patch to fix the issue in synonym node, where it was not horning
> >> > parent
> >> > node while creating in different node, issue was that we were not
> >> > sending
> >> > node properly.
> >> > RM#1611
> >>
> >> That doesn't seem like a reliable way to get the correct parent ID -
> >> what if there are multiple synonyms in different schemas but with the
> >> same name?
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>