Re: [pgAdmin4][PATCH] To fix the issue in table node

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][PATCH] To fix the issue in table node
Date: 2017-05-15 08:53:48
Message-ID: CAKKotZS0b1TeOqTsWzcyCQ08e5N7G_v50yAsBmV_ybaz-Ff0WA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

As there were no proper steps given in RM to re-produce the issue, I
assumed that user tried to delete schema and then click on the table, hence
he got that error.
So I checked the code notice that validation was missing at a location of
error trace mentioned in RM, it assumed that we always get one row from
database.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, May 15, 2017 at 1:57 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Mon, May 15, 2017 at 7:14 AM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA minor patch to add object validation in table node for SQL and
>> Properties tab .
>> RM#2395
>>
>
> I don't see how this relates to the issue reported which is related to
> dropping a schema containing a view (from what I can tell), whereas the
> patch is changing the table module.
>
> FWIW, I can't reproduce the reported issue either.
>
> Can you clarify please?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Harshal Dhumal 2017-05-15 08:59:35 Re: [pgAdmin4][PATCH] To fix the issue with Node rename
Previous Message Dave Page 2017-05-15 08:27:42 Re: [pgAdmin4][PATCH] To fix the issue in table node