Re: PATCH: Fixed Textarea control template [pgAdmin4]

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Fixed Textarea control template [pgAdmin4]
Date: 2016-03-11 08:54:25
Message-ID: CAKKotZS-OWjiJ5ZSOLpOmoFd92xy2CSyaV=4mpZz15_UZxvGaA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

I have sent updated patch to include default rows arguments into sql field
control.

Regards,
Murtuza

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Mar 11, 2016 at 2:03 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> On Fri, Mar 11, 2016 at 1:59 PM, Murtuza Zabuawala <
> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> PFA updated patch for mentioned issue.
>>
> Can please you describe, why did you sent the updated path, what was
> missing in the previous patch?
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com/>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
>>
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Mar 11, 2016 at 1:08 PM, Murtuza Zabuawala <
>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> PFA updated patch to fix an issue in textarea template, if we do not
>>> provide default rows then control then it fails to render it (issue with
>>> yesterday's Arun changes), Causing Sql-Feild Control to break which uses
>>> textarea to render code mirror control.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-03-11 09:06:18 pgAdmin 4 commit: Update ACL parsing for tablespaces to use newer infra
Previous Message Ashesh Vashi 2016-03-11 08:33:01 Re: PATCH: Fixed Textarea control template [pgAdmin4]