Re: Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin

From: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>
To: Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin
Date: 2017-01-20 13:49:43
Message-ID: CAKKotZRm91cU09JRE87Au0H3j8D3PuqQuiT-k7709d_5Y24rPA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

That's strange.

I tested in Chrome, Need check in IE.

Meanwhile can try with Chrome/Firefox?

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Jan 20, 2017 at 7:01 PM, Fahar Abbas <fahar(dot)abbas(at)enterprisedb(dot)com>
wrote:

> Hi Murtaza,
>
> I just applied this patch and issue is still not resolved.
>
> In case of Maintenance DB and Backup database message, *Maintenance job
> created* and *Backup job created* displayed but no other dialogue box
> displayed either process is completed or not.
>
> Screen-shot and pgadmin.log file is attached.
>
> Kind Regards,
>
>
> On Fri, Jan 20, 2017 at 5:35 PM, Murtuza Zabuawala <murtuza.zabuawala@
> enterprisedb.com> wrote:
>
>> Hi Fahar,
>>
>> Could you please test this updated patch?
>>
>>
>> --
>> Regards,
>> Murtuza Zabuawala
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Tue, Jan 17, 2017 at 3:45 PM, Fahar Abbas <
>> fahar(dot)abbas(at)enterprisedb(dot)com> wrote:
>>
>>> Thanks Dave.
>>>
>>> On Tue, Jan 17, 2017 at 3:07 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Not surprising. Don't bother testing that any more for now thanks. I
>>>> suspect it's a simple bug that Ashesh can fix pronto.
>>>>
>>>> On Tue, Jan 17, 2017 at 10:02 AM, Fahar Abbas <
>>>> fahar(dot)abbas(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Issue is also reproducible with PG-9.6 server.
>>>>>
>>>>> Regards,
>>>>>
>>>>>
>>>>> On Tue, Jan 17, 2017 at 2:55 PM, Fahar Abbas <
>>>>> fahar(dot)abbas(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Please attached the log files output from the terminal and
>>>>>> pgAdmin4.log.
>>>>>>
>>>>>> Kind Regards,
>>>>>>
>>>>>>
>>>>>> On Tue, Jan 17, 2017 at 2:46 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>>>
>>>>>>> Thanks. What log output do you get?
>>>>>>>
>>>>>>> On Tue, Jan 17, 2017 at 9:44 AM, Fahar Abbas <
>>>>>>> fahar(dot)abbas(at)enterprisedb(dot)com> wrote:
>>>>>>>
>>>>>>>> Hi Dave.
>>>>>>>>
>>>>>>>> After applying this patch on Windows 2012 server 64 with Python
>>>>>>>> 2.7.11 on EPAS-9.6 server, Maintenance DB and Backup database failed.
>>>>>>>>
>>>>>>>> Please find attached the snapshot.
>>>>>>>>
>>>>>>>> Kind Regards,
>>>>>>>>
>>>>>>>> On Wed, Jan 11, 2017 at 6:19 PM, Dave Page <dpage(at)pgadmin(dot)org>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> On Wed, Jan 11, 2017 at 12:28 PM, Ashesh Vashi <
>>>>>>>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Dave,
>>>>>>>>>>
>>>>>>>>>> On Wed, Jan 11, 2017 at 12:03 PM, Dave Page <dpage(at)pgadmin(dot)org>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> KeyError: u'end_time'
>>>>>>>>>>>
>>>>>>>>>>> The status file contains:
>>>>>>>>>>>
>>>>>>>>>>> {"start_time": "2017-01-11 06:27:20.939703 +0000", "pid": 49363,
>>>>>>>>>>> "exit_code": 0, "end_time": "2017-01-11 06:27:28.613456 +0000"}
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Thanks for reviewing the patch.
>>>>>>>>>> Please find the updated patch.
>>>>>>>>>>
>>>>>>>>>> Changes:
>>>>>>>>>> - Using now ValueError instead of json.JSONDecodeError, which is
>>>>>>>>>> subclass of ValueError, to allow to it to work with 2.6+ python.
>>>>>>>>>> - Checking the existence of value in dict before accessing it.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> That seems to work for me in a brief test on my Mac. :-)
>>>>>>>>>
>>>>>>>>> Fahar; are you able to apply and test this patch on Windows and
>>>>>>>>> Linux, in server and desktop modes? Basically all the external processes
>>>>>>>>> should be tested - backup, restore & maintenance (vacuum) etc). I don't
>>>>>>>>> have any VMs available at the moment due to travel.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>
>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Syed Fahar Abbas
>>>>>>>> Quality Management Group
>>>>>>>>
>>>>>>>> EnterpriseDB Corporation
>>>>>>>> Phone Office: +92-51-835-8874
>>>>>>>> Phone Direct: +92-51-8466803 <+92%2051%208466803>
>>>>>>>> Mobile: +92-333-5409707 <+92%20333%205409707>
>>>>>>>> Skype ID: syed.fahar.abbas
>>>>>>>> Website: www.enterprisedb.com
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Syed Fahar Abbas
>>>>>> Quality Management Group
>>>>>>
>>>>>> EnterpriseDB Corporation
>>>>>> Phone Office: +92-51-835-8874
>>>>>> Phone Direct: +92-51-8466803 <(051)%208466803>
>>>>>> Mobile: +92-333-5409707 <0333%205409707>
>>>>>> Skype ID: syed.fahar.abbas
>>>>>> Website: www.enterprisedb.com
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Syed Fahar Abbas
>>>>> Quality Management Group
>>>>>
>>>>> EnterpriseDB Corporation
>>>>> Phone Office: +92-51-835-8874
>>>>> Phone Direct: +92-51-8466803 <+92%2051%208466803>
>>>>> Mobile: +92-333-5409707 <+92%20333%205409707>
>>>>> Skype ID: syed.fahar.abbas
>>>>> Website: www.enterprisedb.com
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> Syed Fahar Abbas
>>> Quality Management Group
>>>
>>> EnterpriseDB Corporation
>>> Phone Office: +92-51-835-8874
>>> Phone Direct: +92-51-8466803 <(051)%208466803>
>>> Mobile: +92-333-5409707 <0333%205409707>
>>> Skype ID: syed.fahar.abbas
>>> Website: www.enterprisedb.com
>>>
>>
>>
>
>
> --
> Syed Fahar Abbas
> Quality Management Group
>
> EnterpriseDB Corporation
> Phone Office: +92-51-835-8874
> Phone Direct: +92-51-8466803
> Mobile: +92-333-5409707
> Skype ID: syed.fahar.abbas
> Website: www.enterprisedb.com
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-01-20 15:30:02 pgAdmin 4 commit: Python 3 fix for the regression tests
Previous Message Fahar Abbas 2017-01-20 13:31:41 Re: Re: PATCH: RM# 1679 - Background process for "restore" not reporting status back to pgAdmin